From dbac286d8529d6debc0f56fa9a3ea26f78826997 Mon Sep 17 00:00:00 2001 From: Dani Liberman Date: Mon, 18 Sep 2023 14:48:46 +0300 Subject: [PATCH] drm/xe: proper setting of irq enabled flag IRQ enabled flag should be set only after request irq succeeds. Reviewed-by: Ohad Sharabi Signed-off-by: Dani Liberman Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_irq.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c index dec3d518b3fc4..e1126eccb50e6 100644 --- a/drivers/gpu/drm/xe/xe_irq.c +++ b/drivers/gpu/drm/xe/xe_irq.c @@ -579,16 +579,14 @@ int xe_irq_install(struct xe_device *xe) return -EINVAL; } - xe->irq.enabled = true; - xe_irq_reset(xe); err = request_irq(irq, irq_handler, IRQF_SHARED, DRIVER_NAME, xe); - if (err < 0) { - xe->irq.enabled = false; + if (err < 0) return err; - } + + xe->irq.enabled = true; xe_irq_postinstall(xe); -- 2.30.2