From dc6e08b1a2ae262c23e14f5c259b4ca63a554e4f Mon Sep 17 00:00:00 2001 From: Harshit Mogalapalli Date: Mon, 30 Oct 2023 00:08:36 -0700 Subject: [PATCH] ALSA: hda: cs35l41: Fix missing error code in cs35l41_smart_amp() When firmware status is invalid, assign -EINVAL to ret as ret is '0' at that point and returning success is incorrect when firmware status is invalid. Fixes: a51d8ba03a4f ("ALSA: hda: cs35l41: Check CSPL state after loading firmware") Signed-off-by: Harshit Mogalapalli Link: https://lore.kernel.org/r/20231030070836.3234385-1-harshit.m.mogalapalli@oracle.com Signed-off-by: Takashi Iwai --- sound/pci/hda/cs35l41_hda.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index 98a5123e9f50d..b2db8091f0ed6 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -1042,6 +1042,7 @@ static int cs35l41_smart_amp(struct cs35l41_hda *cs35l41) default: dev_err(cs35l41->dev, "Firmware status is invalid: %u\n", fw_status); + ret = -EINVAL; goto clean_dsp; } -- 2.30.2