From dc9aa17841e83b6d6ca5abe295545ca0764e1580 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Fri, 1 Mar 2019 15:51:57 -0500 Subject: [PATCH] bcachefs: Drop a faulty assertion the assertion was meant to check that bch2_journal_reclaim_fast() was always being called, but since the atomic dec can happen outside of j->lock the assertion itself can race Signed-off-by: Kent Overstreet --- fs/bcachefs/journal_reclaim.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/bcachefs/journal_reclaim.c b/fs/bcachefs/journal_reclaim.c index 3b5b646859cb1..431afeab42b00 100644 --- a/fs/bcachefs/journal_reclaim.c +++ b/fs/bcachefs/journal_reclaim.c @@ -333,8 +333,6 @@ journal_get_next_pin(struct journal *j, u64 max_seq, u64 *seq) spin_lock(&j->lock); - BUG_ON(!atomic_read(&fifo_peek_front(&j->pin).count)); - fifo_for_each_entry_ptr(pin_list, &j->pin, *seq) if (*seq > max_seq || (ret = list_first_entry_or_null(&pin_list->list, -- 2.30.2