From de416a9f91f330cf764c9d46bb5faac844f4e9ac Mon Sep 17 00:00:00 2001 From: Yang Li Date: Wed, 31 May 2023 10:02:38 +0800 Subject: [PATCH] leds: cht-wcove: Fix an unsigned comparison which can never be negative The return value from the call to cht_wc_leds_find_freq() is int. However, the return value is being assigned to an unsigned int variable 'ctrl', so making it an int. Eliminate the following warning: drivers/leds/leds-cht-wcove.c:236 cht_wc_leds_set_effect() warn: unsigned 'ctrl' is never less than zero. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5341 Signed-off-by: Yang Li Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20230531020238.102684-1-yang.lee@linux.alibaba.com --- drivers/leds/leds-cht-wcove.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-cht-wcove.c index 0a5c30e5ed5d4..42ba442084109 100644 --- a/drivers/leds/leds-cht-wcove.c +++ b/drivers/leds/leds-cht-wcove.c @@ -223,8 +223,7 @@ static int cht_wc_leds_set_effect(struct led_classdev *cdev, u8 effect) { struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev); - unsigned int ctrl; - int ret; + int ctrl, ret; mutex_lock(&led->mutex); -- 2.30.2