From e22de7d7910ab9490b191da5fac0592214b340d5 Mon Sep 17 00:00:00 2001 From: Sven Schnelle Date: Mon, 28 Nov 2022 19:40:44 +0100 Subject: [PATCH] s390/tty3270: add AID defines Use AID_* instead of hex numbers to make the code a bit easier to read. also convert the if/else blocks to a switch statement in tty3270_read_tasklet(). Signed-off-by: Sven Schnelle Acked-by: Heiko Carstens Tested-by: Niklas Schnelle Signed-off-by: Heiko Carstens --- drivers/s390/char/con3270.c | 8 ++++++-- drivers/s390/char/raw3270.h | 7 +++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/s390/char/con3270.c b/drivers/s390/char/con3270.c index 7ff116c387156..0dea178c0f56c 100644 --- a/drivers/s390/char/con3270.c +++ b/drivers/s390/char/con3270.c @@ -565,7 +565,8 @@ static void tty3270_read_tasklet(unsigned long data) */ input = NULL; len = 0; - if (tp->input->string[0] == 0x7d) { + switch (tp->input->string[0]) { + case AID_ENTER: /* Enter: write input to tty. */ input = tp->input->string + 6; len = tp->input->len - 6 - rrq->rescnt; @@ -579,10 +580,13 @@ static void tty3270_read_tasklet(unsigned long data) /* Clear input area. */ tty3270_update_prompt(tp, NULL, 0); tty3270_set_timer(tp, 1); - } else if (tp->input->string[0] == 0x6d) { + break; + case AID_CLEAR: /* Display has been cleared. Redraw. */ tp->update_flags = TTY_UPDATE_ALL; tty3270_set_timer(tp, 1); + default: + break; } spin_unlock_irq(&tp->view.lock); diff --git a/drivers/s390/char/raw3270.h b/drivers/s390/char/raw3270.h index cdf03677118d2..7e0c88e9c3c21 100644 --- a/drivers/s390/char/raw3270.h +++ b/drivers/s390/char/raw3270.h @@ -82,6 +82,13 @@ #define RAW3270_FIRSTMINOR 1 /* First minor number */ #define RAW3270_MAXDEVS 255 /* Max number of 3270 devices */ +#define AID_CLEAR 0x6d +#define AID_ENTER 0x7d +#define AID_PF3 0xf3 +#define AID_PF7 0xf7 +#define AID_PF8 0xf8 +#define AID_READ_PARTITION 0x88 + /* For TUBGETMOD and TUBSETMOD. Should include. */ struct raw3270_iocb { short model; -- 2.30.2