From e5cfa586d5131979feed2820dee18689a4075e64 Mon Sep 17 00:00:00 2001 From: Russell King Date: Sat, 13 May 2023 11:21:24 +0100 Subject: [PATCH] ARM: dts: armada388-clearfog: add missing phy-modes The DSA framework has got more picky about always having a phy-mode, particularly for the CPU port. Add the missing phy-mode properties for every port which does not have an integrated PHY. Add a phy-mode property to the ethernet interface facing the switch as this was configured using SGMII - as the switch is actually using 1000base-x, let's have some consistency between the two link partners. Additionally, the cpu label has never actually been used in the binding, so remove it. Signed-off-by: Russell King (Oracle) Reviewed-by: Andrew Lunn Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-388-clearfog.dts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/armada-388-clearfog.dts b/arch/arm/boot/dts/armada-388-clearfog.dts index 95299167dcf58..32c569df142ff 100644 --- a/arch/arm/boot/dts/armada-388-clearfog.dts +++ b/arch/arm/boot/dts/armada-388-clearfog.dts @@ -47,6 +47,8 @@ ð1 { /* ethernet@30000 */ + phy-mode = "1000base-x"; + fixed-link { speed = <1000>; full-duplex; @@ -129,8 +131,9 @@ port@5 { reg = <5>; - label = "cpu"; ethernet = <ð1>; + phy-mode = "1000base-x"; + fixed-link { speed = <1000>; full-duplex; @@ -141,6 +144,8 @@ /* 88E1512 external phy */ reg = <6>; label = "lan6"; + phy-mode = "rgmii-id"; + fixed-link { speed = <1000>; full-duplex; -- 2.30.2