From ee6ad13705286b19f5ffc19000b1d1574208efc9 Mon Sep 17 00:00:00 2001 From: Janga Rahul Kumar Date: Tue, 13 Jun 2023 15:07:40 +0530 Subject: [PATCH] drm/Xe: Use EOPNOTSUPP instead of ENOTSUPP ENOTSUPP is not a standard Unix error should use EOPNOTSUPP instead. v2: Update commit description (Aravind) Reviewed-by: Aravind Iddamsetty Signed-off-by: Janga Rahul Kumar Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_engine.c | 2 +- drivers/gpu/drm/xe/xe_mmio.c | 4 ++-- drivers/gpu/drm/xe/xe_sync.c | 6 +++--- drivers/gpu/drm/xe/xe_vm.c | 8 ++++---- drivers/gpu/drm/xe/xe_wait_user_fence.c | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_engine.c b/drivers/gpu/drm/xe/xe_engine.c index fd39da8594426..49d92f089242c 100644 --- a/drivers/gpu/drm/xe/xe_engine.c +++ b/drivers/gpu/drm/xe/xe_engine.c @@ -612,7 +612,7 @@ int xe_engine_create_ioctl(struct drm_device *dev, void *data, if (XE_IOCTL_ERR(xe, e->vm && xe_vm_in_compute_mode(e->vm) != !!(e->flags & ENGINE_FLAG_COMPUTE_MODE))) { - err = -ENOTSUPP; + err = -EOPNOTSUPP; goto put_engine; } diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c index f7a7f996b37f0..f1336803b9157 100644 --- a/drivers/gpu/drm/xe/xe_mmio.c +++ b/drivers/gpu/drm/xe/xe_mmio.c @@ -495,7 +495,7 @@ int xe_mmio_ioctl(struct drm_device *dev, void *data, fallthrough; case DRM_XE_MMIO_8BIT: /* TODO */ case DRM_XE_MMIO_16BIT: /* TODO */ - ret = -ENOTSUPP; + ret = -EOPNOTSUPP; goto exit; } } @@ -513,7 +513,7 @@ int xe_mmio_ioctl(struct drm_device *dev, void *data, fallthrough; case DRM_XE_MMIO_8BIT: /* TODO */ case DRM_XE_MMIO_16BIT: /* TODO */ - ret = -ENOTSUPP; + ret = -EOPNOTSUPP; } } diff --git a/drivers/gpu/drm/xe/xe_sync.c b/drivers/gpu/drm/xe/xe_sync.c index 5acb37a8b2ab1..7786b908a3fda 100644 --- a/drivers/gpu/drm/xe/xe_sync.c +++ b/drivers/gpu/drm/xe/xe_sync.c @@ -120,7 +120,7 @@ int xe_sync_entry_parse(struct xe_device *xe, struct xe_file *xef, switch (sync_in.flags & SYNC_FLAGS_TYPE_MASK) { case DRM_XE_SYNC_SYNCOBJ: if (XE_IOCTL_ERR(xe, no_dma_fences && signal)) - return -ENOTSUPP; + return -EOPNOTSUPP; if (XE_IOCTL_ERR(xe, upper_32_bits(sync_in.addr))) return -EINVAL; @@ -138,7 +138,7 @@ int xe_sync_entry_parse(struct xe_device *xe, struct xe_file *xef, case DRM_XE_SYNC_TIMELINE_SYNCOBJ: if (XE_IOCTL_ERR(xe, no_dma_fences && signal)) - return -ENOTSUPP; + return -EOPNOTSUPP; if (XE_IOCTL_ERR(xe, upper_32_bits(sync_in.addr))) return -EINVAL; @@ -173,7 +173,7 @@ int xe_sync_entry_parse(struct xe_device *xe, struct xe_file *xef, case DRM_XE_SYNC_USER_FENCE: if (XE_IOCTL_ERR(xe, !signal)) - return -ENOTSUPP; + return -EOPNOTSUPP; if (XE_IOCTL_ERR(xe, sync_in.addr & 0x7)) return -EINVAL; diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c index b8a0fe24d1d0c..6edac7d4af870 100644 --- a/drivers/gpu/drm/xe/xe_vm.c +++ b/drivers/gpu/drm/xe/xe_vm.c @@ -1819,10 +1819,10 @@ static int vm_set_error_capture_address(struct xe_device *xe, struct xe_vm *vm, return -EINVAL; if (XE_IOCTL_ERR(xe, !(vm->flags & XE_VM_FLAG_ASYNC_BIND_OPS))) - return -ENOTSUPP; + return -EOPNOTSUPP; if (XE_IOCTL_ERR(xe, vm->async_ops.error_capture.addr)) - return -ENOTSUPP; + return -EOPNOTSUPP; vm->async_ops.error_capture.mm = current->mm; vm->async_ops.error_capture.addr = value; @@ -3072,7 +3072,7 @@ int xe_vm_bind_ioctl(struct drm_device *dev, void *data, struct drm_file *file) if (VM_BIND_OP(bind_ops[0].op) == XE_VM_BIND_OP_RESTART) { if (XE_IOCTL_ERR(xe, !(vm->flags & XE_VM_FLAG_ASYNC_BIND_OPS))) - err = -ENOTSUPP; + err = -EOPNOTSUPP; if (XE_IOCTL_ERR(xe, !err && args->num_syncs)) err = EINVAL; if (XE_IOCTL_ERR(xe, !err && !vm->async_ops.error)) @@ -3096,7 +3096,7 @@ int xe_vm_bind_ioctl(struct drm_device *dev, void *data, struct drm_file *file) if (XE_IOCTL_ERR(xe, !vm->async_ops.error && async != !!(vm->flags & XE_VM_FLAG_ASYNC_BIND_OPS))) { - err = -ENOTSUPP; + err = -EOPNOTSUPP; goto put_engine; } diff --git a/drivers/gpu/drm/xe/xe_wait_user_fence.c b/drivers/gpu/drm/xe/xe_wait_user_fence.c index 6c8a60c600871..3122374341d6a 100644 --- a/drivers/gpu/drm/xe/xe_wait_user_fence.c +++ b/drivers/gpu/drm/xe/xe_wait_user_fence.c @@ -143,7 +143,7 @@ int xe_wait_user_fence_ioctl(struct drm_device *dev, void *data, if (XE_IOCTL_ERR(xe, !vm->async_ops.error_capture.addr)) { xe_vm_put(vm); - return -ENOTSUPP; + return -EOPNOTSUPP; } addr = vm->async_ops.error_capture.addr; -- 2.30.2