From f4853e1c321edb48af229ad5ac85076790d34968 Mon Sep 17 00:00:00 2001 From: Bartosz Golaszewski Date: Fri, 15 Feb 2019 11:42:59 +0100 Subject: [PATCH] nvmem: core: don't check the return value of notifier chain call blocking_notifier_call_chain() returns the value returned by the last registered callback. A positive return value doesn't indicate an error and an nvmem device should correctly register irrespective of any notifier callback failures. Drop the retval check. Fixes: bee1138bea15 ("nvmem: add a notifier chain") Cc: stable@vger.kernel.org Signed-off-by: Bartosz Golaszewski Acked-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman --- drivers/nvmem/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 9dd07eae1f3ec..f24008b668269 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -688,9 +688,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) if (rval) goto err_remove_cells; - rval = blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem); - if (rval) - goto err_remove_cells; + blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem); return nvmem; -- 2.30.2