From f78d5e1168e08429bc948d09b6dc11fec5e019f7 Mon Sep 17 00:00:00 2001 From: Andy Shevchenko Date: Thu, 1 Sep 2022 16:23:34 +0300 Subject: [PATCH] regmap: trace: Remove useless check for NULL for bulk ops If the buffer pointer is NULL we already are in troubles since regmap bulk API expects caller to provide valid parameters, it dereferences that without any checks before we call for traces. Moreover, the current code will print garbage in the case of buffer is NULL and length is not 0. Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20220901132336.33234-1-andriy.shevchenko@linux.intel.com Signed-off-by: Mark Brown --- drivers/base/regmap/trace.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/base/regmap/trace.h b/drivers/base/regmap/trace.h index 04329ba68ec55..e92edc4f4ca52 100644 --- a/drivers/base/regmap/trace.h +++ b/drivers/base/regmap/trace.h @@ -82,8 +82,7 @@ DECLARE_EVENT_CLASS(regmap_bulk, __assign_str(name, regmap_name(map)); __entry->reg = reg; __entry->val_len = val_len; - if (val) - memcpy(__get_dynamic_array(buf), val, val_len); + memcpy(__get_dynamic_array(buf), val, val_len); ), TP_printk("%s reg=%x val=%s", __get_str(name), -- 2.30.2