From fbf14104dabe91e6c3b5544f9289eebc94a52c93 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Wed, 1 Sep 2021 18:06:01 -0400 Subject: [PATCH] bcachefs: Improve an error message When we detect an invalid key being inserted, we should print what code was doing the update. Signed-off-by: Kent Overstreet --- fs/bcachefs/btree_update_leaf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/bcachefs/btree_update_leaf.c b/fs/bcachefs/btree_update_leaf.c index 3a59f10e0b879..5e57ff5a5ceba 100644 --- a/fs/bcachefs/btree_update_leaf.c +++ b/fs/bcachefs/btree_update_leaf.c @@ -577,7 +577,9 @@ static inline int do_bch2_trans_commit(struct btree_trans *trans, char buf[200]; bch2_bkey_val_to_text(&PBUF(buf), c, bkey_i_to_s_c(i->k)); - bch_err(c, "invalid bkey %s on insert: %s\n", buf, invalid); + bch_err(c, "invalid bkey %s on insert from %ps -> %ps: %s\n", + buf, (void *) trans->ip, + (void *) i->ip_allocated, invalid); bch2_fatal_error(c); } btree_insert_entry_checks(trans, i); -- 2.30.2